chore(sonar): exclude e2e + suppress go:S4036 PATH hotspots#8
Merged
Conversation
Two narrow tightenings to cut Sonar noise: - ui/e2e/** added to sonar.exclusions. Playwright specs are test scaffolding (own runner, fixtures, repeat boilerplate) and were showing up as ~45% duplicated source code, polluting the dup metric. - go:S4036 (PATH variable usage) suppressed project-wide via sonar.issue.ignore.multicriteria. ctm is a CLI orchestrator that resolves user-installed tools (git, tmux, claude, gh) through \$PATH on whatever box it's running on; hardcoded absolutes aren't viable across macOS / Linux / Homebrew. Was firing on 30 lines without flagging a real risk. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui/e2e/**tosonar.exclusions— Playwright specs were inflating dup density (45% oncreate-session.spec.ts).go:S4036("Make sure the PATH variable only contains fixed, unwriteable directories") project-wide. Justification baked into the config: ctm is a CLI orchestrator that intentionally resolves user-installed tools (git, tmux, claude, gh) via $PATH; absolute paths aren't viable across macOS/Linux/Homebrew. Drops the 30 outstanding hotspots in one shot.Expected effect on next main scan
security_hotspots: 30 → ~0duplicated_lines_density: 1.8% → ~1.4% (drops e2e contribution)🤖 Generated with Claude Code